docs(self-hosted): handle reverse proxy cors issues for ingest endpoints #12513
+92
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aldy505 is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
Can I get your eyes on this? @hubertdeng123 @bc-sentry |
| @@ -71,6 +71,21 @@ server { | |||
| proxy_buffer_size 128k; | |||
| proxy_buffers 4 256k; | |||
|
|
|||
| # Handle CORS-related headers for ingest endpoints. | |||
There was a problem hiding this comment.
Why is this necessary? It would be helpful to understand why these changes are being made to see if this is indicative of a larger issue, especially since it's not something common we've seen
There was a problem hiding this comment.
Linking the discord thread could give helpful context
There was a problem hiding this comment.
AFAIK it was this: https://discord.com/channels/621778831602221064/1334066733752909855
Oh, also here, by myself: https://discord.com/channels/621778831602221064/796028405833007104/1169197966460985395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Someone on Discord pointed out that they had CORS issues from the browser when submitting events to Sentry. This patch is to make sure that would never happen.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES