Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RN Custom Metrics to use Sentry.setMeasurement #12496

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

krystofwoldrich
Copy link
Member

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

Fixes getsentry/sentry-react-native#4488

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:55pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 9:55pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 9:55pm

@recurser
Copy link

I reported the origin issue - confirming that this fixes it 👍 Thanks!

@krystofwoldrich
Copy link
Member Author

@recurser Thank you for the confirmation.

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) February 3, 2025 21:41
Copy link

codecov bot commented Feb 3, 2025

Bundle Report

Changes will increase total bundle size by 1.06kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.63MB 1.07kB (0.01%) ⬆️
sentry-docs-client-array-push 9.31MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.63MB -0.0%
../instrumentation.js -3 bytes 965.23kB -0.0%
9523.js -3 bytes 941.45kB -0.0%
../app/[[...path]]/page.js.nft.json 359 bytes 374.34kB 0.1%
../app/platform-redirect/page.js.nft.json 359 bytes 374.25kB 0.1%
../app/sitemap.xml/route.js.nft.json 359 bytes 372.22kB 0.1%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 866.04kB -0.0%
static/chunks/9557-*.js -3 bytes 391.11kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/mGHYYfup02rZr-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/mGHYYfup02rZr-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/l80_Bm3Ieee2gGuZzW-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/l80_Bm3Ieee2gGuZzW-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

@krystofwoldrich krystofwoldrich merged commit ae675d9 into master Feb 3, 2025
11 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-rn-fix-custom-performance-metrics branch February 3, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getCurrentScope().getTransaction() is undefined in Sentry React Native v6.5.0
3 participants