Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Contributing to Docs on Alert and Expandable components #12485

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

inventarSarah
Copy link
Collaborator

@inventarSarah inventarSarah commented Jan 28, 2025

DESCRIBE YOUR PR

Updated the Components page in our "Contributing to Docs" to provide information on how to use the updated Alert and Expandable components.

#12466
#12468

closes #12053

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 7:34am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 7:34am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 7:34am

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@inventarSarah
Copy link
Collaborator Author

@coolguyzone Do you want to have a look at this?
(It would be great if you could @ anyone you think might want to take a look too - thanks!)

@chargome chargome requested a review from coolguyzone February 3, 2025 15:57
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🫡

@inventarSarah
Copy link
Collaborator Author

Thanks, @coolguyzone for your support 👍

Copy link

codecov bot commented Feb 4, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.63MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.31MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.63MB -0.0%
../instrumentation.js -3 bytes 965.23kB -0.0%
9523.js -3 bytes 941.45kB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 866.04kB -0.0%
static/chunks/9557-*.js -3 bytes 391.11kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/LLsNHo8Wy1Eg3lzIb074-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/LLsNHo8Wy1Eg3lzIb074-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/TePq5LhApqpE0B5zpgqEx/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/TePq5LhApqpE0B5zpgqEx/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@inventarSarah inventarSarah merged commit 0f3fa1b into master Feb 4, 2025
11 checks passed
@inventarSarah inventarSarah deleted the smi/contributing/alert-expandable branch February 4, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve callouts
3 participants