Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: respect the stored platform on non platform pages #12477

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented Jan 27, 2025

currently, search relies on the page pathname to prioritize sdks/platform search results

but when the user navigates to a non platform page while they have some platform previously selected on the sidebar,
search ignores that platform

this PR makes search respect that selection

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 5:05pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 5:05pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 5:05pm

Copy link

codecov bot commented Jan 27, 2025

Bundle Report

Changes will increase total bundle size by 646 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.7MB 185 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.38MB 461 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.63MB -0.0%
../instrumentation.js -3 bytes 965.23kB -0.0%
9523.js -3 bytes 941.45kB -0.0%
../app/[[...path]]/page.js 28 bytes 525.19kB 0.01%
8899.js 166 bytes 28.83kB 0.58%

Files in ../app/[[...path]]/page.js:

  • ./src/components/home.tsx → Total Size: 17.59kB

Files in 8899.js:

  • ./app/not-found.tsx → Total Size: 2.59kB

  • ./app/not-found.tsx → Total Size: 4.35kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/ 166 bytes 2.62MB 0.01%
/[[...path]] 28 bytes 3.08MB 0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 866.04kB -0.0%
static/chunks/9557-*.js -3 bytes 391.11kB -0.0%
static/chunks/4746-*.js 424 bytes 19.97kB 2.17%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/chunks/app/not-*.js 43 bytes 2.86kB 1.53%
static/6btt2NJGIAQKHdMbKamkA/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/6btt2NJGIAQKHdMbKamkA/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/bsCW8bR63X1AJItMxEbM2/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/bsCW8bR63X1AJItMxEbM2/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/app/not-*.js:

  • ./app/not-found.tsx → Total Size: 4.32kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/ 43 bytes 12.82kB 0.34%

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the description on what this PR does exactly?

@a-hariti a-hariti merged commit 6e50a75 into master Feb 4, 2025
13 checks passed
@a-hariti a-hariti deleted the smarter-search branch February 4, 2025 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants