Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak some navigation ui to make onboarding more intuitive #11774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coolguyzone
Copy link
Collaborator

@coolguyzone coolguyzone commented Nov 8, 2024

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:16pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:16pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:16pm

Copy link

codecov bot commented Nov 8, 2024

Bundle Report

Changes will decrease total bundle size by 41 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.59MB 35 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

@@ -1,5 +1,5 @@
---
title: Product Walkthroughs
title: What Is Sentry?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: What Is Sentry?
title: What Is Sentry?

Thanks for taking a stab at this! While changing this to "What is Sentry" works really nicely as a navigational experience if you're starting on the homepage. I feel like "Product Walkthroughs" work better as the title on the sidenav if you're navigating from within the docs. Product Walkthroughs is probably one of our most important/highly trafficked sections of the product docs and I'd be worried about changing that to "what's sentry", which is a pretty narrow and potentially vague heading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants