Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: widget masks overlap when navigating between screens. #2486

Conversation

thisames
Copy link
Contributor

📜 Description

At first I thought it would be necessary to implement a way to scrape widgets by context, as I did in posthog, but I realized that your code was already correct, it just needs one adjustment.

applying debugVisitOnstageChildren to your children does exactly what we were looking for. a way to "separate the elements that are hidden and not interactive from the active elements in the current context of the screen"

💡 Motivation and Context

widget masks overlap when navigating between screens.

#2309

💚 How did you test it?

I just did several tests with different navigations and applications, checking and debugging the widgets

2024-12-11.21-50-19.mp4

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@vaind vaind force-pushed the fix-mask-overlay-flutter-session-replay branch 2 times, most recently from 5d414f2 to 2d34c24 Compare January 13, 2025 17:34
@vaind vaind closed this Jan 14, 2025
@vaind vaind force-pushed the fix-mask-overlay-flutter-session-replay branch from 2d34c24 to ec50b21 Compare January 14, 2025 12:24
@vaind
Copy link
Collaborator

vaind commented Jan 14, 2025

I've created an in-repo PR so that CI runs completely: #2576
but then messed up a bit and force-pushed here instead of to the other PR so this shows as empty - sorry about that. In any case, your original commit is in the internal PR and will be merged together with the changelog. Thank you for your contribution @thisames

@thisames
Copy link
Contributor Author

I've created an in-repo PR so that CI runs completely: #2576 but then messed up a bit and force-pushed here instead of to the other PR so this shows as empty - sorry about that. In any case, your original commit is in the internal PR and will be merged together with the changelog. Thank you for your contribution @thisames

no problem, good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants