-
-
Notifications
You must be signed in to change notification settings - Fork 372
Re-Revert "Structured Logs: Add log APIs in Hub and Client"
#6737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # Sources/Swift/Tools/SentryLogger.swift # Tests/SentryTests/SentryLoggerTests.swift # Tests/SentryTests/SentrySDKInternalTests.swift
# Conflicts: # Sentry.xcodeproj/project.pbxproj
# Conflicts: # Sources/Sentry/SentryClient.m # Sources/Sentry/SentryHub.m # Sources/Sentry/include/SentryClient+Logs.h # Sources/Swift/Helper/SentrySDK.swift # Sources/Swift/Tools/SentryLogBatcher.swift # Sources/Swift/Tools/SentryLogger.swift # sdk_api.json
Hub and Client Re-RevertHub and Client Re-Revert"
Hub and Client Re-Revert"Hub and Client"
Hub and Client"Hub and Client"
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6737 +/- ##
=============================================
- Coverage 85.092% 85.032% -0.060%
=============================================
Files 452 452
Lines 27643 27680 +37
Branches 12139 12155 +16
=============================================
+ Hits 23522 23537 +15
- Misses 4077 4101 +24
+ Partials 44 42 -2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f5666e7 | 1227.08 ms | 1260.18 ms | 33.10 ms |
| 0529194 | 1237.23 ms | 1254.67 ms | 17.44 ms |
| 7f4bf81 | 1241.73 ms | 1270.66 ms | 28.93 ms |
| 5c05f83 | 1224.73 ms | 1246.90 ms | 22.16 ms |
| 7f26f16 | 1220.62 ms | 1255.04 ms | 34.42 ms |
| 04435e6 | 1226.81 ms | 1252.56 ms | 25.75 ms |
| 795dd39 | 1216.88 ms | 1245.47 ms | 28.59 ms |
| 5bf2b17 | 1213.53 ms | 1238.54 ms | 25.01 ms |
| aadbffe | 1228.73 ms | 1251.59 ms | 22.86 ms |
| 3e12a49 | 1218.13 ms | 1260.57 ms | 42.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f5666e7 | 23.75 KiB | 963.18 KiB | 939.43 KiB |
| 0529194 | 23.74 KiB | 891.02 KiB | 867.28 KiB |
| 7f4bf81 | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| 5c05f83 | 23.75 KiB | 1022.78 KiB | 999.03 KiB |
| 7f26f16 | 23.75 KiB | 1.02 MiB | 1016.66 KiB |
| 04435e6 | 23.75 KiB | 1010.41 KiB | 986.66 KiB |
| 795dd39 | 23.75 KiB | 908.16 KiB | 884.41 KiB |
| 5bf2b17 | 23.75 KiB | 913.27 KiB | 889.52 KiB |
| aadbffe | 23.75 KiB | 912.77 KiB | 889.02 KiB |
| 3e12a49 | 23.75 KiB | 1.01 MiB | 1006.48 KiB |
Previous results on branch: denrase/logs-in-hub-and-client-re-revert
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c084ac2 | 1219.55 ms | 1255.50 ms | 35.95 ms |
| a0e8e98 | 1216.70 ms | 1248.60 ms | 31.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c084ac2 | 24.15 KiB | 1.00 MiB | 1001.52 KiB |
| a0e8e98 | 24.15 KiB | 1.02 MiB | 1017.46 KiB |
# Conflicts: # Sources/Swift/Helper/SentrySDK.swift # Sources/Swift/Tools/SentryLogBatcher.swift # Sources/Swift/Tools/SentryLogger.swift # Tests/SentryTests/SentryLoggerTests.swift
# Conflicts: # Sources/Swift/Helper/SentrySDK.swift # Tests/SentryTests/SentrySDKTests.swift
# Conflicts: # Tests/SentrySwiftLogTests/SentryLogHandlerTests.swift
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denrase
📜 Description
capture(log:scope:)methods toClientloggerAPI toHubSentryLog, so users can actually create them for hub/client method usage.💡 Motivation and Context
Reverts #6727 to restore #6518. Fix adapted from #6724.
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.