-
-
Notifications
You must be signed in to change notification settings - Fork 372
fix: Crash when user feedback block is nil #6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6642 +/- ##
========================================
Coverage ? 85.171%
========================================
Files ? 452
Lines ? 27669
Branches ? 12116
========================================
Hits ? 23566
Misses ? 4059
Partials ? 44
Continue to review full report in Codecov by Sentry.
|
3687518 to
ef98d4d
Compare
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 995b436 | 1217.54 ms | 1254.26 ms | 36.72 ms |
| f37e3fe | 1230.24 ms | 1254.51 ms | 24.27 ms |
| 0ac4c65 | 1236.85 ms | 1267.84 ms | 30.98 ms |
| 339539a | 1219.58 ms | 1254.63 ms | 35.05 ms |
| ebc3a34 | 1236.24 ms | 1261.02 ms | 24.78 ms |
| 781f560 | 1232.83 ms | 1263.56 ms | 30.73 ms |
| e98d6f5 | 1228.51 ms | 1258.85 ms | 30.34 ms |
| b709887 | 1193.52 ms | 1216.74 ms | 23.22 ms |
| 37183fe | 1212.33 ms | 1238.92 ms | 26.59 ms |
| 3279d4e | 1215.76 ms | 1256.45 ms | 40.69 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 995b436 | 23.75 KiB | 1.02 MiB | 1016.76 KiB |
| f37e3fe | 23.75 KiB | 919.70 KiB | 895.95 KiB |
| 0ac4c65 | 23.75 KiB | 968.24 KiB | 944.50 KiB |
| 339539a | 23.75 KiB | 968.24 KiB | 944.50 KiB |
| ebc3a34 | 23.75 KiB | 919.91 KiB | 896.16 KiB |
| 781f560 | 23.75 KiB | 1.02 MiB | 1016.46 KiB |
| e98d6f5 | 23.75 KiB | 933.03 KiB | 909.28 KiB |
| b709887 | 23.75 KiB | 1.01 MiB | 1016.14 KiB |
| 37183fe | 23.75 KiB | 913.63 KiB | 889.87 KiB |
| 3279d4e | 23.75 KiB | 938.32 KiB | 914.57 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for finding this!
If you had done
options.configureUserFeedback = nilthe app would crash, this fixes itCloses #6643