ref: Refactor SentryClient init

[noahsmartin]

The many paths through this logic confused me, but it wasn't actually confusing, it was just written confusingly so I cleaned it up.

For example this allowed me to delete deleteOldEnvelopeItems which was only ever YES

I removed a few @objc annotations that weren't needed anymore also

#skip-changelog

Closes #6626

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
3889	1	3888	55

View the top 1 failed test(s) by shortest run time

iOS_Swift_UITests.LaunchUITests::testBreadcrumbData

Stack Traces | 0s run time

.../iOS-Swift/iOS-Swift-UITests/UITestHelpers.swift:5 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1229.83 ms	1263.23 ms	33.41 ms
Size	23.75 KiB	1.01 MiB	1016.05 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
e0e5391	1191.21 ms	1243.14 ms	51.93 ms
fc6557e	1226.40 ms	1249.88 ms	23.48 ms
aa0b738	1236.78 ms	1253.08 ms	16.31 ms
32e7197	1226.91 ms	1245.48 ms	18.56 ms
8da82b4	1220.08 ms	1248.24 ms	28.16 ms
89e74bc	1197.06 ms	1228.73 ms	31.67 ms
e648312	1223.18 ms	1265.32 ms	42.14 ms
65ebbdb	1233.96 ms	1255.79 ms	21.83 ms
93c76b0	1236.92 ms	1265.82 ms	28.90 ms
e3ebff3	1223.47 ms	1249.27 ms	25.80 ms

App size

Revision	Plain	With Sentry	Diff
e0e5391	23.74 KiB	1022.21 KiB	998.46 KiB
fc6557e	23.75 KiB	866.68 KiB	842.93 KiB
aa0b738	23.74 KiB	872.75 KiB	849.00 KiB
32e7197	23.75 KiB	866.69 KiB	842.94 KiB
8da82b4	23.75 KiB	913.63 KiB	889.88 KiB
89e74bc	23.75 KiB	969.78 KiB	946.03 KiB
e648312	23.75 KiB	1.01 MiB	1016.13 KiB
65ebbdb	23.75 KiB	902.33 KiB	878.59 KiB
93c76b0	23.75 KiB	946.69 KiB	922.95 KiB
e3ebff3	23.75 KiB	878.48 KiB	854.73 KiB

Previous results on branch: sanitizeClientInit

Startup times

Revision	Plain	With Sentry	Diff
4c42ff1	1214.14 ms	1245.41 ms	31.27 ms
027f41d	1223.95 ms	1249.28 ms	25.32 ms

App size

Revision	Plain	With Sentry	Diff
4c42ff1	23.74 KiB	1.01 MiB	1016.25 KiB
027f41d	23.74 KiB	1.01 MiB	1016.05 KiB

[itaybre]

Stamped with some comments