Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Oct 31, 2025

When using @_spi(Private) import Sentry it is possible to set a higher frame rate using options.sessionReplay.frameRate = 10.

Due to a UInt / UInt this will result in a time interval since last frame of 0 ms instead of e.g. 100ms.

This PR fixes the division.

No changelog needed because frameRate is internal.

#skip-changelog

Closes #6624

@codecov
Copy link

codecov bot commented Oct 31, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3893 1 3892 55
View the top 1 failed test(s) by shortest run time
iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:14 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@philprime philprime enabled auto-merge (squash) October 31, 2025 16:58
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1195.40 ms 1219.23 ms 23.84 ms
Size 23.75 KiB 1.01 MiB 1016.05 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b41e6a7 1201.65 ms 1246.12 ms 44.47 ms
daeb716 1215.41 ms 1246.52 ms 31.11 ms
535ebd9 1194.59 ms 1219.84 ms 25.26 ms
b709887 1193.52 ms 1216.74 ms 23.22 ms
e98d6f5 1228.51 ms 1258.85 ms 30.34 ms
76f74df 1238.29 ms 1261.22 ms 22.94 ms
0b6776b 1230.18 ms 1262.06 ms 31.88 ms
9389467 1218.62 ms 1244.86 ms 26.24 ms
86eb6d5 1224.95 ms 1251.82 ms 26.87 ms
561321a 1229.60 ms 1252.55 ms 22.95 ms

App size

Revision Plain With Sentry Diff
b41e6a7 23.75 KiB 908.03 KiB 884.28 KiB
daeb716 23.75 KiB 928.16 KiB 904.41 KiB
535ebd9 23.75 KiB 1008.67 KiB 984.92 KiB
b709887 23.75 KiB 1.01 MiB 1016.14 KiB
e98d6f5 23.75 KiB 933.03 KiB 909.28 KiB
76f74df 23.75 KiB 879.61 KiB 855.86 KiB
0b6776b 23.75 KiB 968.23 KiB 944.49 KiB
9389467 23.75 KiB 866.51 KiB 842.76 KiB
86eb6d5 23.74 KiB 1.02 MiB 1016.53 KiB
561321a 23.75 KiB 963.18 KiB 939.43 KiB

Previous results on branch: philprime/fix-frame-rate

Startup times

Revision Plain With Sentry Diff
35f05b3 1228.57 ms 1267.89 ms 39.32 ms

App size

Revision Plain With Sentry Diff
35f05b3 23.74 KiB 1.02 MiB 1016.74 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changelog needed because frameRate is internal.

If I'm not mistaken, this fixes a critical bug. I think this PR is worth a changelog entry.

@philprime philprime disabled auto-merge November 3, 2025 09:12
@philprime philprime enabled auto-merge (squash) November 3, 2025 09:12
@philprime philprime merged commit 0a40a02 into main Nov 3, 2025
177 of 181 checks passed
@philprime philprime deleted the philprime/fix-frame-rate branch November 3, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(session-replay): Fix conversion of frame rate to time interval

4 participants