feat: use undici to download binary #2993
Open
+64
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
JPeer264
force-pushed
the
jp/upgrade-node-fetch
branch
from
b341615 to
99bef89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #1810)
This removes
node-fetchentirely. We could have upgrade tonode-fetch@3, but this one requires ESM-only, which we can't support (we still need CJS support for our@sentry/*bundler packages).With this PR we use now
undiciwhich also has aProxyAgentincluded, so we got rid ofhttps-proxy-agentas well.