-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(dev): Fix and expand .envrc
checks
#522
base: main
Are you sure you want to change the base?
Conversation
f2e0a89
to
76d9360
Compare
Hey! I'm definitely not against these changes. To be clear, part of the reason we haven't improved If you take a look at I am not against local python, but here are things you should know:
Broadly, if it helps you and you're willing to take responsibility for it, cool! My time likely won't be spent ensuring local python works, and that is just a fair warning. |
This is a rewrite of our
.envrc
file to solve a few problems I ran into getting the repo set up:.python-version
file, but there is no such file (and in fact we.gitignore
any file with that name).cmake
, which is required in order to installonnx
, but we also requiredocker
anddocker-compose
in order to run typechecking and the dev server, respectively.)To solve these problems, this PR makes the following changes:
.python-version
file and it is no longer.gitignore
d.Brewfile
, but it wasn't doing a good job handling the fact that I already haddocker
anddocker-compose
installed, so I switched to only trying to install whatever packages are missing.)-d
rather than-f
to check for the virtual env, since it's a directory.Also, all four checks done by
.envrc
(Python version, CLI packages, virtual env, and pre-commit hooks) are now listed in the readme.Notes:
.envrc
get the user's buy-in before making the first two fixes but not before making the second two. I also made it so dependencies are automatically installed when the env is created.