Add method_or_response= as optional keyword parameter for add() method. #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulsuh
changed the title
markstory
reviewed
Sep 10, 2024
| @@ -778,6 +778,7 @@ def add( | |||
| url: "Optional[_URLPatternType]" = None, | |||
| body: "_Body" = "", | |||
| adding_headers: "_HeaderSet" = None, | |||
| method_or_response: "_HTTPMethodOrResponse" = None, | |||
There was a problem hiding this comment.
Wouldn't adding a method parameter to upsert() get the parameter name alignment you're looking for? We would also need to possibly update replace() and remove(). I think adding a shorter and easier parameter name to those methods is better than expanding add(). The .add() method is by far the most frequently used method of the set and its conventions will be the ones that folks remember.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #734
Adds a keyword parameter
method_or_responseto theadd(...)method. The new keyword parameter is added as the last keyword parameter so that existing code that treats the first and second positional arguments as being assigned to the parametersmethodandurlrespectively continues to work without modification.Unit test of the new functionality (all tests passing) and documentation in the README.rst have been added.