-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added real_adapter_send
parameter to RequestsMock
#671
Conversation
…ow users to set through which function they would like to send real requests * moved type annotations behind IF statement so they are called only during type checking
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
f759a41
to
99358cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be some documentation about this and moto
?
@Seluj78 only if on moto side |
I don't understand your last reply but my thought was that there should be some documentation on |
There will be documentation on Moto's side, after this is released. |
responses/__init__.py
Outdated
@@ -1008,7 +1023,7 @@ def _on_request( | |||
*, | |||
retries: Optional["_Retry"] = None, | |||
**kwargs: Any, | |||
) -> "models.Response": | |||
) -> "Union[models.Response, models.Response]": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this union have two of the same thing?
closes #670
allow to explicitly specify real send for each of the request mocks. That will unblock
moto
and allowmoto
users to use bothresponses
andmoto
at the same time