Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#651] regex compatability for headers matching #663

Merged
merged 5 commits into from
Aug 22, 2023
Merged

[#651] regex compatability for headers matching #663

merged 5 commits into from
Aug 22, 2023

Conversation

geetptl
Copy link
Contributor

@geetptl geetptl commented Aug 9, 2023

Attempt at #651.

  • Changes in header_matcher function.
  • Instead of using simple list equality, it now checks for either regex or simple string check.
  • Added tests test_request_matches_headers_regex, test_request_matches_headers_regex_strict_match

responses/matchers.py Outdated Show resolved Hide resolved
@beliaev-maksim beliaev-maksim self-assigned this Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ad22f54) 100.00% compared to head (a2e2da1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #663   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         2880      2968   +88     
=========================================
+ Hits          2880      2968   +88     
Files Changed Coverage Δ
responses/matchers.py 100.00% <100.00%> (ø)
responses/tests/test_matchers.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markstory markstory merged commit e5a6159 into getsentry:master Aug 22, 2023
16 checks passed
@markstory
Copy link
Member

Thank you 🎉

@jgehrcke
Copy link

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants