-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow urllib3>=1.25.10 #659
chore: allow urllib3>=1.25.10 #659
Conversation
setup.py
Outdated
@@ -18,7 +18,7 @@ | |||
|
|||
install_requires = [ | |||
"requests>=2.30.0,<3.0", | |||
"urllib3>=2.0.0,<3.0", | |||
"urllib3>=1.25.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"urllib3>=1.25.10", | |
"urllib3>=1.25.10,<3.0", |
We should keep the upper bound. Future versions of urllib3 may require changes in responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Done.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 2875 2875
=========================================
Hits 2875 2875 ☔ View full report in Codecov by Sentry. |
please add a matrix of tests in CI. We need to test on both 1.x and 2.x otherwise we give a promise that we cannot guarantee |
Thanks. Done, I think. The CI doesn't run for me yet so I'm not 100% certain. |
@beliaev-maksim or @markstory Can one of you enable the workflows to run? Thanks. |
Allow use of urllib3>=1.25.10. By default it will use urllib3>=2 as that is the latest version. But this will allow people to pin urllib3<2 and still use the latest version of requests and responses. Closes: #657
I was able to run the CI over in my fork. And I got the tests to pass. https://github.com/JohnVillalovos/responses/pull/2 |
Allow use of urllib3>=1.25.10. By default it will use urllib3>=2 as that is the latest version. But this will allow people to pin urllib3<2 and still use the latest version of requests and responses.
Closes: #657