Record matcher #641
Record matcher #641
Conversation
# Conflicts: # responses/tests/test_recorder.py
added header matcher recording
| }, | ||
| "strict_match": False, | ||
| }, | ||
| "matcher_import_path": "responses.matchers", |
There was a problem hiding this comment.
hi @markstory
pls have a look on the draft of the recorder.
I have a question/concern how to proceed with replay
considering that we need to support custom matchers, we probably want to import matchers as well.
I found a way how to extract the location of the mather. however, then we need to do import during runtime and local to each function, which does not sound really smart
what could be the options?
I think asking users to import required matchers defeats the purpose of record/replay
There was a problem hiding this comment.
Hrm, importing userland code is possible but it could get messy. I think we're also taking a risk that userland matcher parameters will be 'serializable' into JSON, which isn't guaranteed. We could require that in order to use recording 🤷
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
closes #639
Current PR proposes the implementation of recorder for matchers into yaml (or any other compatible format)