Re-enabled integration tests #3306
Conversation
dgannon991
force-pushed
the
feature/3300/enable-integration-tests
branch
3 times, most recently
from
6ae2c6d to
52847e3
Compare
Signed-off-by: David Gannon <[email protected]>
dgannon991
force-pushed
the
feature/3300/enable-integration-tests
branch
from
52847e3 to
570d37e
Compare
Signed-off-by: David Gannon <[email protected]>
dgannon991
requested review from
schristoff,
sgettys,
bdegeeter,
troy0820 and
kichristensen
as code owners
| @@ -93,124 +93,39 @@ jobs: | |||
| uses: getporter/porter/.github/workflows/integ-reuseable-workflow.yml@main | |||
| with: | |||
| test_name: telemetry_test | |||
| # Reusable workflows only supports 20 jobs | |||
There was a problem hiding this comment.
Is this no longer the case? It is listed as a limitation on the GitHub documentation page
There was a problem hiding this comment.
I had a quick search and could not find it mentioned, so thought I'd give it a go as a test. It seems to work and run them all! Do you have a link handy for the documentation?
There was a problem hiding this comment.
Sorry forgot to add the link, it is written here, https://docs.github.com/en/actions/sharing-automations/reusing-workflows#limitations
| @@ -12,244 +12,147 @@ env: | |||
|
|
|||
| jobs: | |||
| archive_integration_test: | |||
| name: Archive Integration Test | |||
There was a problem hiding this comment.
Why is all the names removed?
There was a problem hiding this comment.
I wanted to make the file consistent with the porter-integration-mr.yml file to make it easier to see if one is missing tests. I noticed that not all of the tests in the integration-release.yml file had names in the first place, so decided to sync on no names. More than happy to go and add names to all tests in both files though if you'd rather :)
There was a problem hiding this comment.
My personal opinion would be to have human friendly names in both places
What does this change
Adds back more of the integration tests into the pipeline (they were already running locally)
What issue does it fix
Closes #3300