Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden-answer appearance for string with external app #6623

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Feb 24, 2025

Closes #6572

Why is this the best possible solution? Were any other approaches considered?

There’s not much to discuss here. We hide the answer when the new appearance is used, similar to how it works with the barcode widget.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It simply adds a new appearance, allowing us to focus primarily on testing it to ensure answers are hidden.

Do we need any specific form for testing your changes? If so, please attach one.

Any form with external widgets (string/integer/decimal) and the new appearance. I've used:
external_widgets_hidden.xlsx
external_widgets.xlsx
which work with CollectAnswersProvider

Does this change require updates to documentation? If so, please file an issue here and include the link below.

getodk/docs#1922

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg merged commit 43b17e9 into getodk:master Mar 6, 2025
6 checks passed
@dbemke
Copy link

dbemke commented Mar 7, 2025

Tested with Success!

Verified on devices with Android 10, 14

Verified cases:

  • the hidden appearance in forms from the issue with Collect Answers Provider installed/unistalled
  • the hidden appearance and values in the hierarchy view
  • RTL
  • quick regression checks in All widget form and external apps

@WKobus
Copy link

WKobus commented Mar 7, 2025

Tested with success

Verified on device with Android 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hidden-answer appearance for string with external app
4 participants