issue: add v9 issue types

[jay-418]

context

implements:

• https://github.com/getlantern/engineering/issues/3893

used by:

• report issue: add v9 issue types lantern#9045

API side:

• https://github.com/getlantern/lantern-cloud/pull/3327

summary

• add SPLIT_TUNNEL, SMART_ROUTING, SERVER_SELECTION, UPGRADE_FAIL (11-14) to the ReportIssueRequest proto and the IssueType constants, matching lantern-cloud's apipb enum

Summary by CodeRabbit

• New Features
  • Added support for reporting issues related to split tunneling, smart routing, server selection, and upgrade failures.

[coderabbitai]

Warning

Review limit reached

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: dc0d4c47-ae70-48db-b71f-153ffa4e42af

📥 Commits

Reviewing files that changed from the base of the PR and between 90b1265 and 37b3503.

⛔ Files ignored due to path filters (1)

• issue/issue.pb.go is excluded by !**/*.pb.go

📒 Files selected for processing (1)

• issue/issue.go

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2945fb44-ee8c-4315-bb16-0704081ab75b

📥 Commits

Reviewing files that changed from the base of the PR and between b1be56e and 90b1265.

⛔ Files ignored due to path filters (1)

• issue/issue.pb.go is excluded by !**/*.pb.go

📒 Files selected for processing (2)

• issue/issue.go
• issue/issue.proto

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The issue type contracts add four new values: split tunneling, smart routing, server selection, and upgrade failures.

Changes

Issue type contract expansion

Layer / File(s)	Summary
Expand issue type enums issue/issue.proto, issue/issue.go	The protobuf ISSUE_TYPE enum and the Go IssueType constants add four corresponding issue types.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: garmr-ulfr

Merge Risk: ⚪ Minimal · up to 90b12

This change adds four issue-type values for v9 features with aligned numeric assignments. No current correctness, compatibility, or deployment risk remains beyond normal checks.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely identifies the addition of v9 issue types, which is the main change in the pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jay/new-types

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟡 Changes recommended

IssueType currently relies on iota/offsets while being cast to the protobuf enum, which is fragile for wire/API compatibility if constants are ever reordered or inserted later.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds the v9 issue-type expansion to Radiance’s issue reporting API so clients can report additional categories that match the lantern-cloud enum.

Changes:

• Added SPLIT_TUNNEL, SMART_ROUTING, SERVER_SELECTION, UPGRADE_FAIL (11–14) to ReportIssueRequest.ISSUE_TYPE.
• Regenerated the Go protobuf bindings to include the new enum values.
• Extended the local IssueType constants to cover the new categories.

File summaries

File	Description
issue/issue.proto	Adds the four new enum values to ReportIssueRequest.ISSUE_TYPE.
issue/issue.pb.go	Regenerated protobuf output to reflect the enum changes.
issue/issue.go	Adds corresponding IssueType constants used by the issue reporter.

Review details

Files not reviewed (1)

• issue/issue.pb.go: Generated file

• Files reviewed: 2/3 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[garmr-ulfr]

LGTM!