-
-
Notifications
You must be signed in to change notification settings - Fork 11k
macOS: avoid using stale tunnel interfaces on reconnect #9080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atavism
wants to merge
9
commits into
main
Choose a base branch
from
atavism/issue-3781
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
56e6e5c
fix(macos): match tunnel descriptors to configured interfaces
atavism f2345de
Merge remote-tracking branch 'origin/main' into atavism/issue-3781
atavism c6663fd
code review updates
atavism 45fa330
Merge remote-tracking branch 'origin/main' into atavism/issue-3781
atavism c25af5e
Merge origin/main into atavism/issue-3781
atavism 94c0fb0
Merge remote-tracking branch 'origin/main' into atavism/issue-3781
atavism 0a4be45
Merge branch 'main' into atavism/issue-3781
atavism ba45daa
Improve macOS tunnel cleanup and reconnect smoke tests (#9096)
atavism f978302
code review updates
atavism File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: getlantern/lantern
Length of output: 5379
🏁 Script executed:
Repository: getlantern/lantern
Length of output: 45670
🏁 Script executed:
Repository: getlantern/lantern
Length of output: 41953
🏁 Script executed:
Repository: getlantern/lantern
Length of output: 34163
🏁 Script executed:
Repository: getlantern/lantern
Length of output: 15009
🌐 Web query:
official Flutter macOS build XCODE_XCCONFIG_FILE environment variable xcconfig💡 Result:
🏁 Script executed:
Repository: getlantern/lantern
Length of output: 7876
🌐 Web query:
Flutter xcodebuild environmentVariablesAsXcodeBuildSettings XCODE_XCCONFIG_FILE source💡 Result:
🏁 Script executed:
Repository: getlantern/lantern
Length of output: 2048
Pass the smoke condition through Flutter's supported Xcode setting path.
XCODE_XCCONFIG_FILEis not consumed by theflutter build macosinvocation. Flutter 3.41.0 forwards onlyFLUTTER_XCODE_*variables toxcodebuild. The PacketTunnel Profile target therefore builds withoutVPN_SMOKE_TEST.The extension omits request loading,
failAfterSettings, forced fallback, and result recording.waitForResultthen can wait 60 seconds and fail forfailed-after-settings; each fallback request would also time out if reached.Suggested fix
🤖 Prompt for AI Agents