Skip to content

Restore sliver scrolling in Action Mode - #9063

Merged
atavism merged 7 commits into
mainfrom
atavism/action-mode-followup
Sep 23, 2026
Merged

atavism merged 7 commits into
mainfrom
atavism/action-mode-followup

Conversation

@atavism

@atavism atavism commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Keep Action Mode’s sliver structure while preserving the small-screen fixes from #9056:

  • Use CustomScrollView with SliverPadding and SliverToBoxAdapter.
  • Preserve the minimum globe height and message wrapping without reintroducing the SliverFillRemaining sizing issue.

Summary by CodeRabbit

  • Bug Fixes
    • Improved scrolling behavior in the Action Mode tab, including on smaller screens and with larger text sizes.
    • Preserved existing content sizing and layout while enabling content outside the globe to scroll as expected.
    • Globe drag interactions continue to rotate the globe without unintentionally moving the surrounding scroll view or pager.

@atavism
atavism requested review from jigar-f and a lite review from Copilot September 15, 2026 23:08
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 6427806b-a3f3-4492-87c6-5b9ac48f6f1f

📥 Commits

Reviewing files that changed from the base of the PR and between 27d3ef1 and 36a7617.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e151fa65-eecf-4b5a-b67f-ee3e24ebd988

📥 Commits

Reviewing files that changed from the base of the PR and between 6c7081e and dc2947a.

📒 Files selected for processing (1)
  • test/features/action_mode/action_mode_widgets_test.dart

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

ActionModeTab now uses CustomScrollView with padded slivers. Its content and sizing remain unchanged. Tests cover small-screen scrolling and globe drag behavior.

Changes

Action mode scrolling

Layer / File(s) Summary
Sliver scroll container and test coverage
lib/features/action_mode/action_mode.dart, test/features/action_mode/action_mode_widgets_test.dart
ActionModeTab replaces SingleChildScrollView with CustomScrollView, SliverPadding, and SliverToBoxAdapter. A new test verifies scrolling on a small screen. The globe drag test updates its scrollable lookup to use CustomScrollView.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e824b

The sliver-based scrolling change includes coverage for small-screen scrolling and globe drag ownership. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: restoring sliver-based scrolling in Action Mode.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch atavism/action-mode-followup

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The widget test should verify that the content actually scrolls.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Restores sliver-based scrolling in Action Mode while preserving small-screen layout fixes.

Changes:

  • Replaces SingleChildScrollView with CustomScrollView and slivers.
  • Preserves minimum globe sizing and wrapped status content.
  • Updates widget test scroll-view lookup.
File summaries
File Summary
lib/features/action_mode/action_mode.dart Restores sliver-based Action Mode layout.
test/features/action_mode/action_mode_widgets_test.dart Updates scrollable lookup; moderate issue remains because actual scrolling is not verified (3 votes).
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/features/action_mode/action_mode_widgets_test.dart
@atavism
atavism requested a review from myleshorton September 18, 2026 16:39
@atavism

atavism commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

@jigar-f Could you take a look at this one

@jigar-f jigar-f left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding it back.

@atavism
atavism merged commit ab0b4b4 into main Sep 23, 2026
9 of 10 checks passed
@atavism
atavism deleted the atavism/action-mode-followup branch September 23, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants