refactor(watch-only): replace unwraps with typed errors and logging#934
Open
alienx5499 wants to merge 1 commit intogetfloresta:masterfrom
Open
refactor(watch-only): replace unwraps with typed errors and logging#934alienx5499 wants to merge 1 commit intogetfloresta:masterfrom
alienx5499 wants to merge 1 commit intogetfloresta:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Notes
This PR improves error handling in
crates/floresta-watch-onlyby removing panic-proneunwrap/expectpaths and replacing them with typed errors, guarded handling, and contextual logging.Main changes:
thiserrorbasedWatchOnlyErrorandKvDatabaseErrorWatchOnlyError::Descriptor(String)and propagate descriptor parsing/derivation errorsOptionhandling anderror!logskv_databaseRelated issues: #463, #86
How to verify the changes you have done?
From repo root:
cargo +nightly fmt -p floresta-watch-only cargo test -p floresta-watch-only cargo clippy -p floresta-watch-only --all-targets --all-features -- -D warningsNote: Overlaps #931 slightly in
maybe_derive_addresses(lib.rs); easy resolve after #931 is onmaster.