feat(chain): add ChainState::open() for load-or-create#925
Open
Sandipmandal25 wants to merge 1 commit intogetfloresta:masterfrom
Open
feat(chain): add ChainState::open() for load-or-create#925Sandipmandal25 wants to merge 1 commit intogetfloresta:masterfrom
Sandipmandal25 wants to merge 1 commit intogetfloresta:masterfrom
Conversation
5d04799 to
105169c
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Notes
Closes #911.
ChainState::new()does not check whether the underlying store is already populated. As a result, calling it on an existing store resets the chain to genesis (height 0).This change introduces
ChainState::open(), which:load_chain_statefirstnew()only if the store is empty (ChainNotInitialized)To keep the API generic over different
ChainStoreimplementations, the method accepts a factory closure instead of aFlatChainStoreConfig. The existingBlockchainError: From<E>bound already covers allDatabaseErrorimplementors via the blanket implementation.On the caller side:
florestad::load_chain_stateand theload_chain_storehelper are replaced with a singleChainState::open()callCouldNotCreateFlatChainStoreerror variant is removedHow to verify
cargo test -p floresta-chain --features flat-chainstore open_resumes_existing_chain_state