feat(docker): add data persistence to docker-compose#834
Open
unwrap-nicolas wants to merge 1 commit intogetfloresta:masterfrom
Open
feat(docker): add data persistence to docker-compose#834unwrap-nicolas wants to merge 1 commit intogetfloresta:masterfrom
unwrap-nicolas wants to merge 1 commit intogetfloresta:masterfrom
Conversation
Member
|
Should be marked as draft until 639 is merged |
Member
|
Why does this need #639? I think you can just drop it and leave the persistence part |
4203acb to
0808d85
Compare
Author
|
@Davidson-Souza actually, my goal with this PR is to get the monitoring stack running 100% smoothly with docker-compose. One issue I noticed was the lack of persistence. However, while fixing that, I realized that PR #639 doesn't fully accomplish its goal of "provisioning grafana dashboards via docker-compose" But your point makes sense. I've updated this PR's description and removed those specific fixes. I also added them as suggestions on PR #639. Thanks for the review! |
18 tasks
0808d85 to
24321a6
Compare
24321a6 to
a383524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Notes
fixed #795
this PR addresses the lack of data persistence and network flexibility in the current
docker-compose.ymlsetup.currently, users running
docker compose upexperience:Changes
Data Persistence:
FLORESTA_DATAenvironment variable to reuse existing local blockchain data (useful for sharing data between native and Docker installations)Network Configuration:
NETWORKenvironment variable to easily switch between Bitcoin networks (bitcoin,signet,testnet,testnet4,regtest)--rpc-addressand--electrum-addressflags, avoiding port conflicts when changing networksDocumentation:
doc/docker.mdwith examples for running different networks and using local data directoriesHow to verify the changes you have done?
Start the stack:
docker compose up -dorNETWORK=signet FLORESTA_DATA=$HOME/.floresta docker compose up