[WIP]Custom names for structs, enums & functions #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Builder::generate_with_definer has been splitted in subfunction for better readability * added type alias GenerationFunction * added NameConvention option on builder
ronan-ditto
force-pushed
the
rd/customizable-naming-templates-eg-namespace-prefixing
branch
from
d1a1ee7 to
8c0a706
Compare
danielhenrymantilla
approved these changes
May 17, 2022
| } | ||
|
|
||
| fn guard(&self) -> String { | ||
| self.guard.unwrap_or( |
There was a problem hiding this comment.
Suggested change
| self.guard.unwrap_or( | |
| self.guard.map_or_else(|| |
| env::var("CARGO_PKG_NAME") | ||
| .unwrap() | ||
| .to_ascii_uppercase() | ||
| )).to_string() |
There was a problem hiding this comment.
Suggested change
| )).to_string() | |
| ), str::to_string) |
|
|
||
| fn guard(&self) -> String { | ||
| self.guard.unwrap_or( | ||
| &format!("__RUST_{}__", |
There was a problem hiding this comment.
Suggested change
| &format!("__RUST_{}__", | |
| format!("__RUST_{}__", |
Comment on lines
+502
to
+504
| Default, | ||
| Suffix(String), | ||
| Prefix(String), |
There was a problem hiding this comment.
🤔 what do you think of:
Suggested change
| Default, | |
| Suffix(String), | |
| Prefix(String), | |
| Default, | |
| Custom(fn(&str) -> String), |
it would be more general, and would still allow suffix and prefix with things like: Custom(|s| format!("{s}_t")).
Otherwise we could handle them all 🤷
Suggested change
| Default, | |
| Suffix(String), | |
| Prefix(String), | |
| Default, | |
| Suffix(String), | |
| Prefix(String), | |
| Custom(fn(&str) -> String), |
There was a problem hiding this comment.
Handling them all is nice because we could handle something like :
#[ffi_export(prefix="PFX")]
struct Foo {...}
danielhenrymantilla
approved these changes
May 17, 2022
ronan-ditto
deleted the
rd/customizable-naming-templates-eg-namespace-prefixing
branch
ronan-ditto
restored the
rd/customizable-naming-templates-eg-namespace-prefixing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better readability