Refactor logging settings to use DittoLogLevel directly #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced `LoggingOptions` with `DittoLogLevel` from the Ditto SDK, removing the reference to custom wrapper type. - Added `isLoggingEnabled` state to separately track logging enablement alongside log levels. - Updated `SettingsModel`: - Refactored `storedLoggingOption` to migrate legacy `UserDefaults` values to `DittoLogLevel` and clean up old keys. - Simplified future storage/retrieval to use `DittoLogLevel` directly. - Modified `SettingsView` constructor to take a `Ditto` instance instead of `LoggingOptions`. These changes simplify logging logic, align with the updated Ditto SDK, and ensure backward compatibility.
rdas-ditto
force-pushed
the
rd/202501-tools-fix
branch
from
d14398c to
f4b513e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR to review required changes to updating the iOS demo app to work with Tools 7.1.0
LoggingOptionswithDittoLogLevelfrom the Ditto SDK, removing the reference to custom wrapper type.isLoggingEnabledstate to separately track logging enablement alongside log levels.SettingsModel:storedLoggingOptionto migrate legacyUserDefaultsvalues toDittoLogLeveland clean up old keys.DittoLogLeveldirectly.SettingsViewconstructor to take aDittoinstance instead ofLoggingOptions.These changes simplify logging logic, align with the updated Ditto SDK, and ensure backward compatibility.