fix: ui render issue when changing pipelines #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Phelps <[email protected]>
markphelps
commented
Dec 4, 2024
ui/src/components/pipeline.tsx
Outdated
| const [selectedNode, setSelectedNode] = useState<PhaseNode | null>(null); | ||
| const [isPanelExpanded, setIsPanelExpanded] = useState(true); | ||
|
|
||
| const { pipeline } = props; | ||
| const { nodes: initNodes, edges: initEdges } = getElements(pipeline); | ||
| const { data: pipeline, isLoading } = useGetPipelineQuery(pipelineId); |
There was a problem hiding this comment.
i will handle isLoading in another PR as I want to display some skeleton nodes or something while loading and this will prob be a bigger change
|
|
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue that was preventing pipelines from rendering correctly when selecting a new one from the sidebar.
Also sorts the pipeline responses so react can better detect if the state actually changed
This pull request includes several changes to both the backend and frontend codebases to improve stability and simplify the state management. The most important changes include sorting entities for stability in the backend, refactoring the frontend to remove redundant state management, and updating components to use new props.
Backend Changes:
server.go: Added sorting for phases, edges, and pipelines by name to ensure stability. [1] [2] [3]Frontend Changes:
pipeline.tsx: Removed thepipelinesSlicestate management and refactored the component to fetch and use pipeline data directly from the API. [1] [2]header.tsx: Updated theHeadercomponent to accept and display thepipelineIdprop instead of using the selected pipeline from the state. [1] [2]layout.tsx: Simplified the layout by removing unnecessary div elements around theOutletcomponent.sidebar.tsx: Added a function to handle pipeline selection and navigation, improving code readability. [1] [2]State Management Changes:
store/index.ts: Removed thepipelinesSlicefrom the Redux store configuration.store/pipelinesSlice.ts: Deleted thepipelinesSliceand related state management code.