-
Notifications
You must be signed in to change notification settings - Fork 325
Fix: JSON import UTF-8 BOM handling issue #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: JSON import UTF-8 BOM handling issue #155
Conversation
Hi. We thought about doing something serverside, but ended up deciding that BOM was not supported by the server - and we preferred solutions that errors if a BOM is sent up. Currently, it still says If you could modify the PR to give a more specific error in this case, we'd take that instead, but we'd like to keep BOM as unsupported. |
Sorry - I didn't follow up on #138 promptly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good - thanks
One comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool looks good. I'll merge it in later.
merged in 42a8752 @Shyam-Raghuwanshi - I made some small changes to your PR to simplify. Take a look - trying to really make the diff more minimal from the previous behavior. |
Fix JSON import UTF-8 BOM handling issue
fix #138
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.