Test Account Pool family failover after inline retry - #3308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
PR #3053 correctly switched accounts when the first upstream response declared a model-family limit, but its short same-account retry used a separate response path. If the first response was an ordinary short 429 and the retry then declared a family limit, that second path returned the 429 without trying another eligible account. PR #3117 later consolidated attempts into one loop and incidentally fixed the root cause on current
main, but no regression test covered the original two-stage response sequence.What changed
Added a shipped Account Pooler plugin test using the Plugin SDK fake-host harness. It drives the exact sequence
sk-oneordinary short 429,sk-onefamily-limit 429, thensk-twosuccess, and asserts the client receives HTTP 200. There is no production, wire-contract, CLI, guide, documentation, credential, quota, or unrelated-provider change.How you verified
sk-one, sk-one;sk-twowas not tried.main: the focused harness test passed withsk-one, sk-one, sk-twoand HTTP 200.pnpm exec turbo run test typecheck build --filter=bb-plugin-account-pool --concurrency=1 --continue --force— 6 tasks passed; 10 test files and 262 tests passed; typecheck passed.pnpm exec oxfmt --check plugins/account-pool/src/server.test.tsandgit diff --check origin/main...HEADpassed.Part of #1552