fix(push-notifications): avoid duplicate macOS notification icons

plugins/push-notifications/client.test.ts

@@ -37,6 +37,25 @@ afterEach(() => {
 });
 
 describe("client system notifications", () => {
+  it.each([
+    { platform: "macos", icon: undefined },
+    { platform: "linux", icon: "http://localhost:3000/icon-192.png" },
+    { platform: "web", icon: "http://localhost:3000/icon-192.png" },
+  ])(
+    "uses the appropriate notification icon on $platform",
+    async ({ platform, icon }) => {
+      if (platform !== "web") vi.stubGlobal("bbDesktop", { platform });
+      const delivery = createClientDelivery(vi.fn());
+      await delivery.deliver(
+        { ...message, channels: [platform === "web" ? "web" : "desktop"] },
+        true,
+      );
+      expect(TestNotification.instances).toHaveLength(1);
+      expect(TestNotification.instances[0]?.options.icon).toBe(icon);
+      delivery.dispose();
+    },
+  );
+
   it("deduplicates windows, navigates on click, and cleans up on disposal", async () => {
     const navigate = vi.fn();
     const first = createClientDelivery(navigate);

plugins/push-notifications/client.ts

@@ -31,9 +31,17 @@ export function createClientDelivery(navigate: (threadId: string) => void) {
 
   function display(message: ClientNotification): void {
     if (disposed || notificationPermission() !== "granted") return;
+    const isMacDesktop =
+      "bbDesktop" in window &&
+      typeof window.bbDesktop === "object" &&
+      window.bbDesktop !== null &&
+      "platform" in window.bbDesktop &&
+      window.bbDesktop.platform === "macos";
     const notification = new Notification(message.title, {
       body: message.body,
-      icon: new URL("/icon-192.png", window.location.origin).href,
+      ...(isMacDesktop
+        ? {}
+        : { icon: new URL("/icon-192.png", window.location.origin).href }),
       tag: `bb-${message.threadId ?? message.id}`,
     });
     active.add(notification);