fix(account-pool): serialize concurrent credential refreshes - #3112
Closed
smsunarto wants to merge 2 commits into
Closed
fix(account-pool): serialize concurrent credential refreshes#3112smsunarto wants to merge 2 commits into
smsunarto wants to merge 2 commits into
Conversation
This was referenced Sep 5, 2026
SawyerHood
pushed a commit
that referenced
this pull request
Sep 5, 2026
## Human comments ## What was wrong Conversations could switch accounts under load even while their current account was healthy. Losing a warm prompt cache can increase uncached input and latency. Child sessions also missed their parent’s account affinity, and Codex session headers were dropped. ## What changed Keep conversations on eligible accounts and let children inherit an eligible parent’s account. A child can fail over independently. Preserve native session headers, cache keys, and encrypted payloads so routing does not unnecessarily disrupt cache reuse. ## How you verified Quota tests cover failover, staying on the replacement account, and recovery after all accounts exhaust. Both providers’ tests fail with affinity disabled. All 229 plugin tests, typecheck, lint, and formatting passed. Synthetic tests do not measure live cache improvement. Fork branches are stacked; upstream PR diffs are cumulative. <!-- GitButler Footer Boundary Top --> --- This is **part 4 of 4 in a stack** made with GitButler: - <kbd> 4 </kbd> #3117 👈 - <kbd> 3 </kbd> #3116 - <kbd> 2 </kbd> #3115 - <kbd> 1 </kbd> #3112 <!-- GitButler Footer Boundary Bottom --> > AGENT GENERATED
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
When parallel requests needed a token refresh, they could refresh the same account twice and race token rotation, risking authentication failures that interrupt otherwise valid sessions.
What changed
Requests now share one refresh per account, so parallel work reuses the refreshed credential. Other accounts can continue independently.
How you verified
The duplicate-refresh regression fails before the fix and passes after. All 35 server tests, typecheck, lint, and formatting passed.
Fork branches are stacked; upstream PR diffs are cumulative.
This is part 1 of 4 in a stack made with GitButler: