Keep CI pnpm version in manifest lockstep - #3083
Merged
ymichael merged 1 commit intoSep 4, 2026
Merged
Conversation
ymichael
deleted the
bb/fixer-keep-ci-pnpm-version-in-manifest-lockstep-thr_z7m38pj5yv
branch
September 4, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
PR #3046 replaced registry-heavy pnpm bootstrapping with a direct, checksum-verified GitHub Release download, but the shared workspace setup stopped checking its requested pnpm version against the root
packageManagerdeclaration. The duplicated pins could therefore drift while CI continued testing and packaging with a different pnpm release than the project contract.What changed
install-pnpm.shnow reads the rootpackageManagerthroughGITHUB_WORKSPACEand rejects a version mismatch before checksum lookup or download.The direct checksum-verified installer is otherwise unchanged. There are no host-daemon protocol, CLI, guide, or product behavior changes.
How you verified
pnpm exec turbo run test typecheck --filter=@bb/scripts --force— 22 files and 130 tests passed; package typecheck passed.bash -n .github/actions/setup-workspace/install-pnpm.sh, targetedoxfmt --check, andgit diff --check origin/main...HEAD— passed after rebasing onto currentmain.Follow-up to #3046.