Skip to content

Fix rejected steer details ownership - #2412

Merged
ymichael merged 1 commit into
mainfrom
bb/post-merge-fix-keep-rejected-steers-out-of-expan-thr_j943egm6yu
Aug 25, 2026
Merged

Fix rejected steer details ownership#2412
ymichael merged 1 commit into
mainfrom
bb/post-merge-fix-keep-rejected-steers-out-of-expan-thr_j943egm6yu

Conversation

@ymichael

Copy link
Copy Markdown
Collaborator

What was wrong

The lazy expanded-details projection filtered only accepted human steers. Rejected human steers are also root-owned, so a rejected steer spanning a completed work item appeared once in the root timeline and again inside the expanded summary.

What changed

Renamed the shared predicate around the ownership invariant and removed its accepted-status restriction while retaining the human-initiator and steer-kind checks. The persisted-event regression now covers accepted and rejected outcomes and proves each appears once at the root and never in expanded details. No server/daemon wire contract changed; HOST_DAEMON_PROTOCOL_VERSION remains 166.

How you verified

  • Red: pnpm exec turbo run test --filter=@bb/server --force -- --run test/services/threads/timeline-in-turn-window.test.ts failed only the new rejected case (25 passed, 1 failed) because details contained the rejected steer.
  • Green: the same focused command passed 26/26 tests.
  • pnpm exec turbo run test --filter=@bb/thread-view --force passed 368/368 tests.
  • pnpm exec turbo run typecheck --filter=@bb/thread-view --filter=@bb/server passed all 5 Turbo tasks.
  • Changed-file formatting and git diff --check passed.

Fixes #2378

AGENT GENERATED

@ymichael
ymichael merged commit 90db2ae into main Aug 25, 2026
15 checks passed
@ymichael
ymichael deleted the bb/post-merge-fix-keep-rejected-steers-out-of-expan-thr_j943egm6yu branch August 25, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant