Fix rejected steer details ownership - #2412
Merged
ymichael merged 1 commit intoAug 25, 2026
Merged
Conversation
ymichael
deleted the
bb/post-merge-fix-keep-rejected-steers-out-of-expan-thr_j943egm6yu
branch
August 25, 2026 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The lazy expanded-details projection filtered only accepted human steers. Rejected human steers are also root-owned, so a rejected steer spanning a completed work item appeared once in the root timeline and again inside the expanded summary.
What changed
Renamed the shared predicate around the ownership invariant and removed its accepted-status restriction while retaining the human-initiator and steer-kind checks. The persisted-event regression now covers accepted and rejected outcomes and proves each appears once at the root and never in expanded details. No server/daemon wire contract changed;
HOST_DAEMON_PROTOCOL_VERSIONremains 166.How you verified
pnpm exec turbo run test --filter=@bb/server --force -- --run test/services/threads/timeline-in-turn-window.test.tsfailed only the new rejected case (25 passed, 1 failed) because details contained the rejected steer.pnpm exec turbo run test --filter=@bb/thread-view --forcepassed 368/368 tests.pnpm exec turbo run typecheck --filter=@bb/thread-view --filter=@bb/serverpassed all 5 Turbo tasks.git diff --checkpassed.Fixes #2378