fix(acp): normalize OpenCode command results - #2376
Merged
Merged
Conversation
ymichael
force-pushed
the
bb/fix-opencode-command-results-thr_vmuyh6z99m
branch
from
August 25, 2026 03:44
74f84d6 to
944db0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
OpenCode carries command output and exit status in its vendor-specific
rawOutput.outputandrawOutput.metadatafields. The shared ACP command-result parser intentionally recognizes only standardized content and established generic result shapes, so completed OpenCode command rows could lose their output and exit code.What changed
Added an OpenCode ACP dialect that validates the recorded result envelope and normalizes
output,metadata.output, andmetadata.exitonly when interpreting an OpenCode command. Standard ACP content, Cursor-style streams, grok's result fields, and generic ACP behavior retain precedence. The built-in OpenCode provider now declares the dialect, and the custom-agent configuration guide and bb-cli skill listopencodeas a supported dialect. There are no host-daemon wire-contract changes, soHOST_DAEMON_PROTOCOL_VERSIONis unchanged.How you verified
pnpm exec turbo run test --filter=@bb/provider-bridge-acp -- src/dialect.test.ts src/delta-translation.test.tspnpm exec turbo run typecheck --filter=@bb/provider-bridge-acp --filter=bb-plugin-provider-acppnpm exec turbo run test --filter=@bb/provider-bridge-acp --filter=bb-plugin-provider-acpFixes: N/A (no linked issue)