Separate declaration key coverage from lifecycle startup - #2356
Merged
ymichael merged 1 commit intoAug 24, 2026
Merged
Conversation
ymichael
deleted the
bb/ci-flake-fix-runtime-changed-declaration-bridge-thr_xb85zm8fai
branch
August 24, 2026 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
PR #2084 removed avoidable TypeScript fixture transforms from this test, but the unified provider-harness work in #2325 later moved it back onto the TypeScript scripted-echo bridge while preserving three serial real-process launches. The packages shard makes each tsx-backed startup compete with many other workers; the redundant third launch pushed the test over its unchanged 15-second cap. Under controlled contention, the request log reached the third process's initialize request but timed out before its thread/start request, confirming cumulative process startup as the cause rather than a polling deadline. No bridge process remained after the timed-out worker exited.
What changed
Successive capability-declaration fingerprints at one artifact hash now have deterministic coverage in bridge-launch-process-key.test.ts. The end-to-end lifecycle test retains the minimum real-process boundary: two equal declarations share one initialized bridge, then one changed declaration initializes a distinct second bridge. This keeps assertions for hangs, process reuse, and process distinction while removing the third serial launch. The 15-second timeout is unchanged. This is test-only; there is no production, wire, CLI, guide, or protocol-version change.
I rejected a timeout increase because scheduler contention is only the reproduction condition. I also kept two real bridges instead of replacing the lifecycle boundary with an injected process factory, because two processes are the minimum needed to prove end-to-end distinction.
How you verified