Stabilize empty plugin update scheduler regression - #2338
Merged
ymichael merged 1 commit intoAug 24, 2026
Merged
Conversation
ymichael
deleted the
bb/ci-flake-fix-plugin-update-empty-set-interval-ti-thr_mkwitqde5r
branch
August 24, 2026 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The empty-plugin scheduler regression inherited the file's heavyweight Git-plugin integration fixture. Before it could assert the scheduled delay, the test installed and loaded a Git plugin, then called the public removal path solely to manufacture an empty database. That removal performs lifecycle disposal, managed-file cleanup, and CLI-skill synchronization unrelated to periodic scheduling. The passing main run already spent about 3.3 seconds in this test; locally it reached 4.790 seconds, and under ordinary contention the removal did not finish before Vitest's 5-second default timeout. The scheduler assertion itself is synchronous and deterministic.
What changed
Move the empty-set scheduling regression into a small fixture that owns an in-memory SQLite database with no installed plugins and injects the scheduler callback directly. The assertion remains exact: starting periodic checks with no eligible rows must schedule one six-hour delay. The fixture explicitly stops its service and closes its database.
This is test-only. There is no server/daemon wire change, CLI or configuration surface, or documentation change.
How you verified
Test timed out in 5000msfailure beforeservice.remove("updater")completed.pnpm exec turbo run test --filter=@bb/server --force -- test/services/plugins/plugin-update.test.ts— 27 tests passed.pnpm exec turbo run test --filter=@bb/server --force— 210 test files passed, 1 skipped; 2,002 tests passed.pnpm exec turbo run typecheck --filter=@bb/server— passed.pnpm exec turbo run build --filter=@bb/server— passed.git diff --check— passed.No matching GitHub issue was found, so this PR does not include a
Fixes #Nreference.