Keep prompt draft visible with voice controls in action row - #1458
Conversation
|
🚨 SLOP COP 🚨 · I am SlopCop. I am reviewing this pull request for security, code quality, performance, architecture, and user behavior. |
SawyerHood
left a comment
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
ELI5: This change keeps your typed prompt on screen while the microphone controls use the bottom action row.
I found one medium accessibility issue. The visible editor still accepts keyboard input during recording and transcription. Pointer input cannot edit it. I left an inline comment with the reproduction and a suggested fix.
The security review found no issue. This change does not alter microphone access, audio handling, transcription, storage, or network behavior.
The performance review found no product issue. The change reuses the existing voice bar and keeps the editor mounted. The codebase scan found no duplicate voice-control implementation or useful larger refactor. Some old grid and opacity transition classes are now unnecessary, but that cleanup is not required here.
Validation results:
- The full app test suite passed with 2,638 tests.
- The focused prompt tests passed with 118 tests.
- The
@bb/apptype check passed. - The pull request checks passed.
- The Ladle browser check kept the draft visible.
- The voice overlay matched the action-row bounds.
- The cancel and confirm controls remained visible.
- The browser also reproduced keyboard edits during recording.
|
Acknowledged the informational security, performance, and architecture review notes. The final candidate continues to reuse the existing voice recorder, waveform, transcription API, permission flow, and data handling; the additional work is limited to prompt-box layout, transition timing/presence, and accessibility state. Final CI and the focused review loop are green. |
…prompt-ui-thr_852qfv9sc7
Summary
Verification
pnpm exec turbo run typecheck --filter=@bb/app: passed.git diff --check: passed.CORRECTafter validated findings were fixed.BB-Thread-ID: thr_852qfv9sc7