Skip to content

Keep prompt draft visible with voice controls in action row - #1458

Merged
brsbl merged 6 commits into
mainfrom
bb/fix-microphone-on-prompt-ui-thr_852qfv9sc7
Aug 13, 2026
Merged

Keep prompt draft visible with voice controls in action row#1458
brsbl merged 6 commits into
mainfrom
bb/fix-microphone-on-prompt-ui-thr_852qfv9sc7

Conversation

@brsbl

@brsbl brsbl commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Keep the existing prompt editor and draft visible while recording or transcribing.
  • Render the existing voice controls in the prompt action row, while making the visible draft read-only and removing inactive composer controls from keyboard and assistive-technology navigation.
  • Add lightweight opacity/transform transitions for voice entry, confirmation, and cancellation. Preserve the last valid voice state during exit, skip interaction delay for reduced motion or a hidden document, and insert completed transcription only after the visible confirmation transition.

Verification

  • Focused prompt-box voice regressions: 16 passed.
  • pnpm exec turbo run typecheck --filter=@bb/app: passed.
  • Prettier and git diff --check: passed.
  • Review loop: two second-pass reviewers returned CORRECT after validated findings were fixed.
  • Real-product QA on the final commit:
    • Recording/cancel completed five times at 390×844, 768×900, 1440×900, and 3440×1440 with no clipping, overflow, state flash, or drift.
    • Existing draft content remained visible and unchanged while voice input was active.
    • Voice controls matched the action-row bounds; inactive controls were inert and the editor was read-only.
    • Confirm kept the draft unchanged through the exit transition, then appended the transcript.
    • Reduced-motion cancel and confirm completed without the 180 ms visual delay.
  • GitHub checks: passed.

BB-Thread-ID: thr_852qfv9sc7

AGENT GENERATED: by GPT-5.6

@SawyerHood

Copy link
Copy Markdown
Collaborator

🚨 SLOP COP 🚨 · review

I am SlopCop. I am reviewing this pull request for security, code quality, performance, architecture, and user behavior.

Comment thread apps/app/src/components/promptbox/PromptBoxInternal.tsx

@SawyerHood SawyerHood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 SLOP COP 🚨 · review

ELI5: This change keeps your typed prompt on screen while the microphone controls use the bottom action row.

I found one medium accessibility issue. The visible editor still accepts keyboard input during recording and transcription. Pointer input cannot edit it. I left an inline comment with the reproduction and a suggested fix.

The security review found no issue. This change does not alter microphone access, audio handling, transcription, storage, or network behavior.

The performance review found no product issue. The change reuses the existing voice bar and keeps the editor mounted. The codebase scan found no duplicate voice-control implementation or useful larger refactor. Some old grid and opacity transition classes are now unnecessary, but that cleanup is not required here.

Validation results:

  • The full app test suite passed with 2,638 tests.
  • The focused prompt tests passed with 118 tests.
  • The @bb/app type check passed.
  • The pull request checks passed.
  • The Ladle browser check kept the draft visible.
  • The voice overlay matched the action-row bounds.
  • The cancel and confirm controls remained visible.
  • The browser also reproduced keyboard edits during recording.

@brsbl brsbl changed the title Keep voice recording controls in prompt action row Keep prompt draft visible with voice controls in action row Aug 13, 2026
@brsbl

brsbl commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator Author

Acknowledged the informational security, performance, and architecture review notes. The final candidate continues to reuse the existing voice recorder, waveform, transcription API, permission flow, and data handling; the additional work is limited to prompt-box layout, transition timing/presence, and accessibility state. Final CI and the focused review loop are green.

@brsbl
brsbl merged commit c14765a into main Aug 13, 2026
10 checks passed
@brsbl
brsbl deleted the bb/fix-microphone-on-prompt-ui-thr_852qfv9sc7 branch August 13, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants