Add split spotlight toggle - #1433
Conversation
|
🚨 SLOP COP 🚨 · I am the SlopCop. I am now reviewing this pull request for security, code quality, performance, architecture, and end-to-end behavior. |
| @@ -394,6 +396,8 @@ const ICON_MAP = { | |||
| Smartphone: SmartPhone01Icon, | |||
There was a problem hiding this comment.
🚨 slopcop/review — Regenerate all downstream icon artifacts
This shared icon map feeds the plugin registry and the generated plugin starter template. The follow-up commit updates packages/plugin-registry/r/icon.json, but it does not update packages/templates/src/generated/plugin-starter-files.generated.ts. Fresh @bb/templates typecheck and test runs fail, and the two related CI jobs fail for the same stale output. Run the repository generators and commit every changed artifact.
There was a problem hiding this comment.
🚨 slopcop/review — Resolved in 747f9b9
The new commit updates the generated plugin starter. The new package test job passes. No action remains for this finding.
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
ELI5: This adds a lightbulb to the active split. It turns split fading on or off and remembers the choice.
Final result: I found no remaining issue.
Resolved during review
- At commit
6404906, fresh template checks failed because a generated starter file was stale. - Commit
747f9b9added that generated file while I posted this review. - The new package test job now passes. I replied to the inline finding with this update.
Security
I found no security issue. This change only adds local UI state and local storage persistence.
Code and architecture
The code reuses createBooleanPreferenceAtom. It keeps the toggle in one component. I found no harmful duplicate or contract change.
Performance
I found no blocking performance issue. The pane count has an eight-pane limit. The preference changes only after a toggle or a storage event.
Validation
- The app typecheck passed at
838f6f1. - The 49 focused app tests passed at
838f6f1. - Browser QA passed with two splits. The button moved with focus and persisted both states after reload.
- Fresh template checks reproduced the stale output at
6404906. Commit747f9b9supplied the missing output.
This run started at 838f6f1, as the review marker states. I also checked the later generated-file commits.
…toggle-thr_95ia458gsa # Conflicts: # packages/plugin-sdk/bundled-types/bb-plugin-sdk.d.ts # packages/templates/src/generated/plugin-sdk-dts.generated.ts
…toggle-thr_95ia458gsa # Conflicts: # apps/app/src/views/thread-detail/ThreadDetailHeader.test.tsx # packages/templates/src/generated/plugin-sdk-dts.generated.ts
Split spotlighting is optional, persists across sessions, and is controllable by people and agents.
What changed
Idea01IconandLightbulbOffIconspotlightandclear-spotlightto the SDK andbb thread panecommandVerification