Render raw thread IDs as mention pills - #1345
Merged
Merged
Conversation
Collaborator
|
🚨 SLOP COP 🚨 · I am SlopCop. I started this review under the I will check security, code quality, performance, architecture, and the user path. |
SawyerHood
reviewed
Aug 11, 2026
SawyerHood
reviewed
Aug 11, 2026
SawyerHood
reviewed
Aug 11, 2026
SawyerHood
reviewed
Aug 11, 2026
SawyerHood
reviewed
Aug 11, 2026
SawyerHood
reviewed
Aug 11, 2026
SawyerHood
reviewed
Aug 11, 2026
SawyerHood
left a comment
Collaborator
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
ELI5: This change turns a thread ID into a name tag and a link. It is like putting a clear label on a toy box. The main idea works. Some labels can open the wrong box or make the app do too much work.
Findings
- High — Unbounded thread lookups. Each unknown raw ID creates one GET request and one real-time subscription. A long message can create thousands.
- Medium — Remote image requests. Regular generated agent text now uses Markdown. A visible preview can load a remote image before the user expands it.
- Medium — Unlimited preview work. The first preview line has no limit. A 500 KiB synthetic line took about 482 ms to parse.
- Medium — Wrong project links. A cross-project thread resource can receive a route for the current timeline project.
- Medium — Path suffix matches. A path such as
/tmp/thr_dcwivn5n8wcan become a pill and start a request. - Medium — Duplicate ID contract. The UI copies the database grammar. It also excludes valid rows that use the older NanoID format.
The new query path needs a bounded batch resolver. The ID grammar also needs one shared contract. These changes remove duplicate policy and control network work.
Checks
- The full app suite passed with 2,509 tests across 332 files.
- The Turbo app type check passed.
git diff --check origin/main...HEADpassed.- The User Message story showed one linked pill and one literal code token.
- The Split Workspace story showed correct title and message pills.
- The browser showed no visible clipping or layout error.
- The security, quality, performance, and architecture reviews found no XSS or unsafe regular expression.
The GPT-5.6 review gate returned REQUEST CHANGES. I used the GitHub comment action only.
…-ids-in-thr_kwj29ra6ep # Conflicts: # apps/app/src/components/thread/timeline/rows/UserMessage.stories.tsx
…-ids-in-thr_kwj29ra6ep # Conflicts: # apps/app/src/components/thread/timeline/GeneratedConversationMessage.test.tsx # packages/server-contract/src/api/threads.ts
- bump the plugin SDK for the new thread resolver contract\n- preserve raw-ID boundaries across Markdown formatting\n- keep unresolved authored links intact\n- prevent truncated code spans from manufacturing mention pills
…-ids-in-thr_kwj29ra6ep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thr_IDs as linked thread mention pills in user, agent, generated, and side-chat message content.Verification
scripts/bb-dev-app current --desktop.