Improving code style of careprofessional module - #71
Open
mateusmanuel wants to merge 1 commit into
Open
Conversation
|
|
||
| def deactive(self, organization): | ||
| return super(CareProfessionalManager, self).get_query_set().filter(active=False, studentprofile__id__isnull=True, person__organization = organization).order_by('person__name') | ||
| return super(CareProfessionalManager, self).get_query_set().filter(active=False, |
Contributor
There was a problem hiding this comment.
Please be more consistent when breaking big lines into small ones.
Also try to reduce them into 80 characters per line or less.
This is an example on how it can be:
def deactive(self, organization):
return super(CareProfessionalManager, self).get_query_set() \
.filter(active=False,
studentprofile__id__isnull=True,
person__organization=organization).order_by(
'person__name')
Contributor
Author
There was a problem hiding this comment.
What do you think about this indentation? I think that is more consistent.
def deactive(self, organization):
return super(CareProfessionalManager, self).get_query_set() \
.filter(active=False, studentprofile__id__isnull=True,
person__organization=organization) \
.order_by('person__name')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this change only variable names, spaces and indentation has been changed. And all changes are done based on pylint, a lint tool that use PEP8 patterns.