Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken unit test - test_evadb_client #1454

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

Tanish0019
Copy link

Problem

Unit test suite is broken. (Last run)
Broken test - CMDClientTest::test_evadb_client
Error: RuntimeError: There is no current event loop in thread 'MainThread'
The test runs fine when run individually but fails when whole suite is run together because other asyncio tests update the asyncio loop settings and policies.

Solution

Update test class to extend from IsolatedAsyncioTestCase which provides better isolation when running multiple asyncio test units.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @Tanish0019, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify that your PR is up-to-date with georgia-tech-db/eva master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.

@Tanish0019
Copy link
Author

Hi @xzdandy, I was just playing around with the project and caught this quick fix so thought about contributing back. Currently the build is failing in the Install Evadb package step unrelated to my change. Do you know if this is a known issue or we can trigger a retry maybe? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant