Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supporting spaces in column names for csv files #1388

Merged
merged 5 commits into from
Dec 3, 2023
Merged

feat: supporting spaces in column names for csv files #1388

merged 5 commits into from
Dec 3, 2023

Conversation

fikremen
Copy link
Contributor

takes reverse quote id, removes back ticks, and converts it to simple id.

americast
americast approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@americast americast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fikremen!

@xzdandy xzdandy added this to the V0.3.10 milestone Nov 28, 2023
xzdandy
xzdandy approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It looks good. Could we add a note in the documentation on using reverse quote for space in column names?

@xzdandy xzdandy merged commit e5a9190 into georgia-tech-db:staging Dec 3, 2023
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@americast americast americast approved these changes

@xzdandy xzdandy xzdandy approved these changes

Assignees

@fikremen fikremen

Labels
User Experience
Projects
EVA Public Roadmap ⚡🚀
Status: Done
Milestone
V0.3.10
Development

Successfully merging this pull request may close these issues.
3 participants
@fikremen @xzdandy @americast