Hackernews data source #1378
Open
Hackernews data source #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new data source integration for HackerNews in EvaDB. The integration allows users to connect to HackerNews and retrieve data from various tables such as "items," "users," "top_stories," "new_stories," "best_stories," "ask_stories," "show_stories," "job_stories," and "updates."
…ckerNews data source integration. The documentation provides a brief description of each table, outlining their purpose and the type of information they store. The tables covered include: ``items``, ``users``, ``top_stories``, ``new_stories``, ``best_stories``, ``ask_stories``, ``show_stories``, ``job_stories``, and ``updates``. 1. Added table descriptions in reStructuredText (rst) format under `evadb/docs/source/reference/databases/hackernews.rst`. 2. Updated the table of contents (`evadb/docs/_toc.yml`) to include the new HackerNews documentation.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hello @Nekronos-SPN, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify that your PR is up-to-date with
georgia-tech-db/evamasterbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.
|
There are conflicts from #1362. Please fix. Thanks! |
|
Hello @kaushikravichandran! The long integration test is returning the following error, even tho the library is included in the requirements.txt. The linter test is stating the following: Could you give me a hand on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add HackerNews Data Source Integration and Documentation
This pull request introduces a new data source integration for HackerNews in EvaDB. The integration allows users to connect to HackerNews and retrieve data from various tables such as "items," "users," "top_stories," "new_stories," "best_stories," "ask_stories," "show_stories," "job_stories," and "updates."
Changes Made:
Data Source Integration:
evadb/third_party/databases/hackernews/containing the necessary files:__init__.py,requirements.txt, andhackernews_handler.py.HackerNewsHandlerclass inhackernews_handler.pythat inherits fromDBHandlerand provides methods for connecting, disconnecting, checking connection, and retrieving data.Configuration Parameters:
max_itemfor limiting rows, a list oftables, and the definition ofcolumnsfor each table are provided during initialization.Documentation:
hackernews.rstunderevadb/docs/source/reference/databaseswith information on the HackerNews data source integration. Updated_toc.ymlto include the new documentation.