Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(climate): deprecate aux_heating feature #486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions custom_components/midea_ac_lan/climate.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ def supported_features(self):
return ClimateEntityFeature.TARGET_TEMPERATURE | \
ClimateEntityFeature.FAN_MODE | \
ClimateEntityFeature.PRESET_MODE | \
ClimateEntityFeature.SWING_MODE | \
ClimateEntityFeature.AUX_HEAT
ClimateEntityFeature.SWING_MODE

@property
def min_temp(self):
Expand Down Expand Up @@ -114,10 +113,6 @@ def target_temperature(self):
def current_temperature(self):
return self._device.get_attribute("indoor_temperature")

@property
def is_aux_heat(self):
return self._device.get_attribute("aux_heating")

@property
def preset_modes(self):
return self._preset_modes
Expand Down Expand Up @@ -200,12 +195,6 @@ def update_state(self, status):
except Exception as e:
_LOGGER.debug(f"Entity {self.entity_id} update_state {repr(e)}, status = {status}")

def turn_aux_heat_on(self) -> None:
self._device.set_attribute(attr="aux_heating", value=True)

def turn_aux_heat_off(self) -> None:
self._device.set_attribute(attr="aux_heating", value=False)


class MideaACClimate(MideaClimate):
def __init__(self, device, entity_key):
Expand Down Expand Up @@ -316,7 +305,7 @@ def __init__(self, device, entity_key):

@property
def supported_features(self):
return ClimateEntityFeature.TARGET_TEMPERATURE | ClimateEntityFeature.AUX_HEAT
return ClimateEntityFeature.TARGET_TEMPERATURE

@property
def target_temperature_step(self):
Expand Down
1 change: 0 additions & 1 deletion doc/AC.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
- Supports fan mode
- Supports swing mode
- Supports preset mode
- Supports auxiliary heating
- Supports build-in fresh air system

### Supported Run-Modes
Expand Down
1 change: 0 additions & 1 deletion doc/AC_hans.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
- 支持风扇模式设定
- 支持摆风模式设定
- 支持预设模式设定
- 支持电辅热
- 支持内置新风系统

### 支持的模式
Expand Down
Loading