Replaced deprecated constants and wildcard imports (HA >= 2023.1) #420

Necroneco · 2024-01-04T07:00:25Z

Replaced deprecated constants, which fixed warning (or error in some cases) in HA 2024.1.0

And replaced wildcard imports, fixed warning in HA 2024.1.1

This will require HA 2023.1

see https://developers.home-assistant.io/blog/2023/12/19/constant-deprecation/

Fixed #415
Fixed #429
Fixed #433
Fixed #444
Fixed #455
Fixed #463
Fixed #476
Fixed #480
Fixed #510

Fixed a typo in hacs.json

Also supported the new climate entity features flag, fixed warning in HA 2024.2

https://developers.home-assistant.io/blog/2024/01/24/climate-climateentityfeatures-expanded

Fixed #479

Merged PR #486 for convenience

Fix blocking call to import_module inside the event loop. (Warning in 2024.5)

ChristophCaina · 2024-01-04T13:14:25Z

are you sure about 2023.1 ?
the deprication for these changes came with 2024.1 - so this should be the min. version (earlier versions would not be supported)

Necroneco · 2024-01-04T13:20:57Z

are you sure about 2023.1 ? the deprication for these changes came with 2024.1 - so this should be the min. version (earlier versions would not be supported)

Yes, I have tested, it works in 2023.1

All deprecation came before 2023.1, and the warning starts from 2024.1

chemelli74 · 2024-01-07T14:30:15Z

Latest Unit were introduced in 2023.1 so since there you can use them safely.
Please merge this PR and release an updated version of this fantastic integration.

chemelli74 · 2024-01-07T20:18:48Z

custom_components/midea_ac_lan/climate.py

-from homeassistant.components.climate import *
-from homeassistant.components.climate.const import *
+from homeassistant.components.climate import ClimateEntity
+from homeassistant.components.climate.const import (


Import should be done always from root.
I suggest to run mypy/pylint o fix all those minor but important warnings

Ok, fixed this.

chemelli74 · 2024-01-09T15:49:24Z

Did a quick test and I this is the result:

2024-01-09 16:45:50.779 INFO (MainThread) [homeassistant.setup] Setup of domain min_max took 0.0 seconds
2024-01-09 16:46:06.247 ERROR (MainThread) [homeassistant.loader] Unexpected exception importing component custom_components.midea_ac_lan
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/loader.py", line 822, in get_component
  File "/usr/local/lib/python3.11/enum.py", line 784, in __getattr__
    raise AttributeError(name) from None
2024-01-09 16:46:06.870 ERROR (MainThread) [homeassistant.setup] Setup failed for custom integration 'midea_ac_lan': Unable to import component: Exception importing custom_components.midea_ac_lan
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/loader.py", line 822, in get_component

Does latest code works fine for you ?

Necroneco · 2024-01-10T07:33:37Z

Did a quick test and I this is the result:

2024-01-09 16:45:50.779 INFO (MainThread) [homeassistant.setup] Setup of domain min_max took 0.0 seconds
2024-01-09 16:46:06.247 ERROR (MainThread) [homeassistant.loader] Unexpected exception importing component custom_components.midea_ac_lan
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/loader.py", line 822, in get_component
  File "/usr/local/lib/python3.11/enum.py", line 784, in __getattr__
    raise AttributeError(name) from None
2024-01-09 16:46:06.870 ERROR (MainThread) [homeassistant.setup] Setup failed for custom integration 'midea_ac_lan': Unable to import component: Exception importing custom_components.midea_ac_lan
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/loader.py", line 822, in get_component

Does latest code works fine for you ?

Yes, works on my device without error. But I only have one Water Drinking Appliance.

What's your HA version?

chemelli74 · 2024-01-10T11:03:17Z

Yes, works on my device without error. But I only have one Water Drinking Appliance.

My devices are Air Conditioner 00000Q18

What's your HA version?

2024.1.2

chemelli74 · 2024-01-27T17:23:52Z

I found the issue and is not related to this PR as expected.

Is related to the commit "restore status sensors of dhw & tbh".
If I remove from midea_devices.py the related changes, all is fine.

This changes are not in use currently as latest release is dated Oct 16th, while the changes were committed on Oct 17th.

Necroneco · 2024-01-29T05:34:04Z

I found the issue and is not related to this PR as expected.

Is related to the commit "restore status sensors of dhw & tbh". If I remove from midea_devices.py the related changes, all is fine.

This changes are not in use currently as latest release is dated Oct 16th, while the changes were committed on Oct 17th.

Thanks for testing. Does this mean that this PR is safe to merge?
And we need open another issue for the error you encountered.

chemelli74 · 2024-01-29T08:07:30Z

Yes this PR is safe to be merged.
We need to understand the issue in the previous commit that is unrelated

chemelli74

Thx @Necroneco, PR works fine

m4rkireland · 2024-03-14T11:28:33Z

Any movement on this one?

erikgieseler · 2024-03-16T19:10:43Z

I found the issue and is not related to this PR as expected.

Is related to the commit "restore status sensors of dhw & tbh". If I remove from midea_devices.py the related changes, all is fine.

This changes are not in use currently as latest release is dated Oct 16th, while the changes were committed on Oct 17th.

Hi, in v0.3.22 the implementation of the C3 heat pump is still buggy, see #353. The changes you had removed are currently only included in the master but are important for the C3 heat pump. Unfortunately, no new version has been released since then. You have to use the master as a starting point for the C3 heat pump implementation, not v0.3.22.

Necroneco · 2024-03-17T05:47:22Z

Hi, in v0.33.2 the implementation of the C3 heat pump is still buggy, see #353. The changes you had removed are currently only included in the master but are important for the C3 heat pump. Unfortunately, no new version has been released since then. You have to use the master as a starting point for the C3 heat pump implementation, not v0.33.2.

Ok, rebased. but it doesn’t really matter, if this PR will be merged

erikgieseler · 2024-03-17T12:24:44Z

I still get the following warnings in the log for my C3 heat pump with the adjustments:

`2024-03-17 13:10:32.143 WARNING (MainThread) [homeassistant.components.climate] Entity midea_ac_lan.142936511731561_climate_zone1 (<class 'custom_components.midea_ac_lan.climate.MideaC3Climate'>) does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method. Please create a bug report at https://github.com/georgezhao2010/midea_ac_lan/issues

2024-03-17 13:10:32.143 WARNING (MainThread) [homeassistant.components.climate] Entity midea_ac_lan.142936511731561_climate_zone1 (<class 'custom_components.midea_ac_lan.climate.MideaC3Climate'>) does not set ClimateEntityFeature.TURN_ON but implements the turn_on method. Please create a bug report at https://github.com/georgezhao2010/midea_ac_lan/issues

2024-03-17 13:10:32.143 WARNING (MainThread) [homeassistant.components.climate] Entity midea_ac_lan.142936511731561_climate_zone1 (<class 'custom_components.midea_ac_lan.climate.MideaC3Climate'>) implements HVACMode(s): off, auto, cool, heat and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/georgezhao2010/midea_ac_lan/issues

`

Necroneco · 2024-03-28T03:13:04Z

I still get the following warnings in the log for my C3 heat pump with the adjustments:

This is related to another issue, and I also fixed it here.

erikgieseler · 2024-03-28T15:05:59Z

I still get the following warnings in the log for my C3 heat pump with the adjustments:

This is related to another issue, and I also fixed it here.

Works perfectly. The error messages have disappeared. Thank you!

# Conflicts: # custom_components/midea_ac_lan/climate.py

javifly · 2024-04-08T17:09:41Z

I've come across the same message... we all get it...

sanderlv · 2024-05-02T17:58:20Z

Not sure if this should be fixed but with HA version 2024.5.0 I get a lot of these:

Logger: homeassistant.components.climate
Source: helpers/deprecation.py:206
integration: Climate (documentation, issues)
First occurred: 19:53:29 (28 occurrences)
Last logged: 19:53:29

SUPPORT_PRESET_MODE was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.PRESET_MODE instead, please report it to the author of the 'midea_ac_lan' custom integration
SUPPORT_SWING_MODE was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.SWING_MODE instead, please report it to the author of the 'midea_ac_lan' custom integration
SUPPORT_TARGET_HUMIDITY was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_HUMIDITY instead, please report it to the author of the 'midea_ac_lan' custom integration
SUPPORT_TARGET_TEMPERATURE was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE instead, please report it to the author of the 'midea_ac_lan' custom integration
SUPPORT_TARGET_TEMPERATURE_RANGE was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE_RANGE instead, please report it to the author of the 'midea_ac_lan' custom integration

Necroneco · 2024-05-03T02:40:08Z

Not sure if this should be fixed but with HA version 2024.5.0 I get a lot of these:

Logger: homeassistant.components.climate Source: helpers/deprecation.py:206 integration: Climate (documentation, issues) First occurred: 19:53:29 (28 occurrences) Last logged: 19:53:29

SUPPORT_PRESET_MODE was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.PRESET_MODE instead, please report it to the author of the 'midea_ac_lan' custom integration SUPPORT_SWING_MODE was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.SWING_MODE instead, please report it to the author of the 'midea_ac_lan' custom integration SUPPORT_TARGET_HUMIDITY was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_HUMIDITY instead, please report it to the author of the 'midea_ac_lan' custom integration SUPPORT_TARGET_TEMPERATURE was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE instead, please report it to the author of the 'midea_ac_lan' custom integration SUPPORT_TARGET_TEMPERATURE_RANGE was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE_RANGE instead, please report it to the author of the 'midea_ac_lan' custom integration

Hello, I think this has already been fixed by this PR

sanderlv · 2024-05-03T04:47:52Z

Then it's not fixed...

wuwentao · 2024-05-21T09:19:57Z

@Necroneco

as current repo is not active more than 6 months.
I have forked it and consider to maintain it in futuer.
https://github.com/wuwentao/midea_ac_lan

PR is welcome

in addition, if you need PR merge permission, I will add more contributors later, it will not limit the repo admin permission in one person.

Thanks

Necroneco changed the title ~~Replaced deprecated constants (HA >= 2023.1)~~ Replaced deprecated constants and wildcard imports (HA >= 2023.1) Jan 7, 2024

chemelli74 reviewed Jan 7, 2024

View reviewed changes

Necroneco mentioned this pull request Jan 27, 2024

Deprecated constant in HA #433

Open

chemelli74 approved these changes Jan 29, 2024

View reviewed changes

Necroneco added 3 commits March 17, 2024 13:45

Replaced deprecated constants

43a9a7d

Replace wildcard imports

9bb7fad

Always import from root

c24f623

Necroneco force-pushed the master branch from def2eb0 to c24f623 Compare March 17, 2024 05:45

Necroneco added 2 commits March 28, 2024 10:33

Fix zip release filename

b48a8bb

Support new ClimateEntityFeature flags

fe3fc48

attilaersek mentioned this pull request Apr 4, 2024

Deprecated is_aux_heat on climate #483

Closed

This was referenced Apr 4, 2024

This stops working in version 2024.10.0. #484

Open

Midea Aircondition don't work after latest hassio #485

Open

fix(climate): deprecate aux_heating feature

a33371d

attilaersek mentioned this pull request Apr 4, 2024

fix(climate): deprecate aux_heating feature #486

Open

This was referenced Apr 5, 2024

Intégration doesn't work for me #482

Closed

DEVICE_CLASS_HUMIDIFIER was used from midea_ac_lan, this is a deprecated constant which will be removed in HA Core 2025.1 #480

Open

Merge PR georgezhao2010#486 from rokam/remove_auxheat

8ac1138

# Conflicts: # custom_components/midea_ac_lan/climate.py

This was referenced Apr 13, 2024

Is_Aux_Heat property not compatible with HA #490

Open

Cannot download integration in HACS #471

Open

CyrielRct mentioned this pull request Apr 27, 2024

Download end with "Unknown error" #506

Open

Necroneco force-pushed the master branch from 741eafa to a471614 Compare May 7, 2024 06:27

Fix blocking call to import_module inside the event loop

50f5f43

Necroneco force-pushed the master branch from a471614 to 50f5f43 Compare May 7, 2024 06:28

wuwentao mentioned this pull request May 13, 2024

midea_ac_lan can't work with error and I'm try to fork and maintain it now #517

Open

erikgieseler mentioned this pull request May 26, 2024

chore(hacs): revert required homeassistant version wuwentao/midea_ac_lan#25

Merged

randyoo mentioned this pull request May 31, 2024

Request for removal of georgezhao2010/midea_ac_lan hacs/integration#3748

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replaced deprecated constants and wildcard imports (HA >= 2023.1) #420

Replaced deprecated constants and wildcard imports (HA >= 2023.1) #420

Necroneco commented Jan 4, 2024 •

edited

Loading

ChristophCaina commented Jan 4, 2024

Necroneco commented Jan 4, 2024 •

edited

Loading

chemelli74 commented Jan 7, 2024

chemelli74 Jan 7, 2024

Necroneco Jan 8, 2024

chemelli74 commented Jan 9, 2024

Necroneco commented Jan 10, 2024

chemelli74 commented Jan 10, 2024

chemelli74 commented Jan 27, 2024

Necroneco commented Jan 29, 2024

chemelli74 commented Jan 29, 2024

chemelli74 left a comment

m4rkireland commented Mar 14, 2024

erikgieseler commented Mar 16, 2024 •

edited

Loading

Necroneco commented Mar 17, 2024

erikgieseler commented Mar 17, 2024

Necroneco commented Mar 28, 2024

erikgieseler commented Mar 28, 2024

javifly commented Apr 8, 2024

sanderlv commented May 2, 2024

Necroneco commented May 3, 2024

sanderlv commented May 3, 2024

wuwentao commented May 21, 2024

Replaced deprecated constants and wildcard imports (HA >= 2023.1) #420

Are you sure you want to change the base?

Replaced deprecated constants and wildcard imports (HA >= 2023.1) #420

Conversation

Necroneco commented Jan 4, 2024 • edited Loading

ChristophCaina commented Jan 4, 2024

Necroneco commented Jan 4, 2024 • edited Loading

chemelli74 commented Jan 7, 2024

chemelli74 Jan 7, 2024

Choose a reason for hiding this comment

Necroneco Jan 8, 2024

Choose a reason for hiding this comment

chemelli74 commented Jan 9, 2024

Necroneco commented Jan 10, 2024

chemelli74 commented Jan 10, 2024

chemelli74 commented Jan 27, 2024

Necroneco commented Jan 29, 2024

chemelli74 commented Jan 29, 2024

chemelli74 left a comment

Choose a reason for hiding this comment

m4rkireland commented Mar 14, 2024

erikgieseler commented Mar 16, 2024 • edited Loading

Necroneco commented Mar 17, 2024

erikgieseler commented Mar 17, 2024

Necroneco commented Mar 28, 2024

erikgieseler commented Mar 28, 2024

javifly commented Apr 8, 2024

sanderlv commented May 2, 2024

Necroneco commented May 3, 2024

sanderlv commented May 3, 2024

wuwentao commented May 21, 2024

Necroneco commented Jan 4, 2024 •

edited

Loading

Necroneco commented Jan 4, 2024 •

edited

Loading

erikgieseler commented Mar 16, 2024 •

edited

Loading