Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance support for limits (RFC5) (#1856) #1892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tomkralidis
Copy link
Member

@tomkralidis tomkralidis commented Dec 31, 2024

Overview

This PR implements RFC5 to provide enhanced limit handling implementation in support of better definition and control on data query limiting.

Related Issue / discussion

#1856

Additional information

This PR needs PSC approval of RFC5 in order to be merged.

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@tomkralidis tomkralidis added enhancement New feature or request OGC API - Features OGC API - Features OGC API - Records OGC API - Records labels Dec 31, 2024
@tomkralidis tomkralidis added this to the 0.20.0 milestone Dec 31, 2024
@tomkralidis tomkralidis changed the title [WIP] enhance support for limits (RFC5) (#1856) enhance support for limits (RFC5) (#1856) Jan 6, 2025
Copy link
Contributor

@totycro totycro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me!

With this change, the old limit setting is now ignored, so if anybody updates to the new version without changing the config, then the default limits apply again. We could detect this old setting and print an informational message .

@pvgenuchten
Copy link
Contributor

very nice Tom, can we also port it to pycsw?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OGC API - Features OGC API - Features OGC API - Records OGC API - Records
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants