BUG: fix writing fids to e.g. GPKG file with use_arrow #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theroggy
changed the title
|
I put the PR as draft while waiting for feedback on the comment here: OSGeo/gdal#11527 (comment) |
| output_gdf = read_dataframe(path, fid_as_index=True, use_arrow=use_arrow) | ||
| output_gdf = output_gdf.reset_index() | ||
|
|
||
| # pyogrio always sets "fid" as index name with `fid_as_index` |
There was a problem hiding this comment.
Question: should we be preserving the original custom name when uisng fid_as_index?
There was a problem hiding this comment.
This has been suggested/requested in this comment: #287 (comment)
I don't mind, but it will be a breaking change...
There was a problem hiding this comment.
Probably fine to leave that for a different PR to deal with that specifically.
theroggy
deleted the
TST-add-test-to-specify-fid-to-be-written-to-GPKG-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #510