Skip to content

add finishOnVertexClick option #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add finishOnVertexClick option #1395

wants to merge 1 commit into from

Conversation

AndrejGajdos
Copy link

More context #1390

Falke-Design
Falke-Design requested changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@Falke-Design Falke-Design left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
I think it will be cleaner if we use finishOn: 'finishBtn' instead of the new option finishOnVertexClick.

Also please add some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Falke-Design Falke-Design Falke-Design requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrejGajdos @Falke-Design