-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support separated (struct) coordinates for all applicable layers #139
Conversation
This looks really great! Thanks! I agree that the simplest and best method for now is to transform the separated coordinates to interleaved coordinates while we're validating them. If you could extend this to other layers, that would be great, and then we can merge. |
Thanks for looking into it and putting this suite of tools together in the first place. Appreciated! Following layers have been updated:
Changes to the following layers were not applicable and thus left untouched:
I did a random check on the scatterplot layer (before and after changes) and it seems to work well. The only one I don't like is the solid polygon layer. It does this conversion twice - one for triangulation (earcut) and the other for rendering. I was thinking to move the geometry to the state object but it'd cause considerable changes to the code. Let me know if you have suggestions on how we could avoid this. Cheers |
@@ -249,7 +251,10 @@ export class GeoArrowSolidPolygonLayer< | |||
recordBatchIdx < geometryColumn.data.length; | |||
recordBatchIdx++ | |||
) { | |||
const polygonData = geometryColumn.data[recordBatchIdx]; | |||
let polygonData = geometryColumn.data[recordBatchIdx]; | |||
if (isGeomSeparate(polygonData)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's just add a comment here, saying
TODO: Note here that we do this conversion twice - one for triangulation (earcut) and the other for rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Thank you! |
Addresses the issue discussed in #137. (Closes #137)
Overview of the proposed changes:
Thoughts:
To do: